Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircuitEditor: Selecting nodes with no name is a bit off #21

Closed
vkashkash opened this issue Sep 5, 2014 · 3 comments
Closed

CircuitEditor: Selecting nodes with no name is a bit off #21

vkashkash opened this issue Sep 5, 2014 · 3 comments
Assignees

Comments

@vkashkash
Copy link

Hello,

When trying to select a node, I notice the selection is a bit off when moving the mouse from below. I think this issue is caused by the use of LabelHeight in GetBounds. Using the label height is fine in the case of a named node; however, I think nodes with no name should not use this to calculate bounds (or at least have the option to ignore label height when there is no name). What do you guys think?

Thanks.

@jhshen
Copy link
Contributor

jhshen commented Sep 5, 2014

Good catch! Will be fixed.

@jhshen jhshen self-assigned this Sep 8, 2014
@jhshen jhshen closed this as completed in b52f2dc Sep 8, 2014
@jhshen
Copy link
Contributor

jhshen commented Sep 8, 2014

A fix has been checked in

@vkashkash
Copy link
Author

I have integrated the fix. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants