Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUIDE] : 코드 리뷰 룰 #1

Open
gaeulzzang opened this issue Aug 18, 2024 · 0 comments
Open

[GUIDE] : 코드 리뷰 룰 #1

gaeulzzang opened this issue Aug 18, 2024 · 0 comments

Comments

@gaeulzzang
Copy link
Member

gaeulzzang commented Aug 18, 2024

📌 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻

코드 리뷰 룰은 뱅크샐러드의 Pn 룰을 차용하되, 특성에 맞게 사용합니다.

P1: 꼭 반영해주세요 (Request changes)
⏩ 기간 내에 반영
ex) P1: ~~~

P2: 반영해도 좋고 넘어가도 좋습니다 (Approve)
⏩ 후 순위, 기간 후에 반영 (만약 맡은 역할이 모두 끝날 시 반영해도 됨.)
ex) P2: ~~~

P3: 그 외 질문 등의 소통 (Approve)
⏩ 질문엔 답변, 그 외는 이모지 답변

💡𝗥𝗲𝗳𝗲𝗿𝗲𝗻𝗰𝗲

https://blog.banksalad.com/tech/banksalad-code-review-culture/

@gaeulzzang gaeulzzang changed the title [FEAT] : Code Review Convention [GUIDE] : 코드 리뷰 룰 Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants