Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MethodParameterLookupBase: replace with IArgumentOperation.Parameter #5556

Open
martin-strecker-sonarsource opened this issue Apr 12, 2022 · 1 comment
Open

MethodParameterLookupBase: replace with IArgumentOperation.Parameter #5556

martin-strecker-sonarsource opened this issue Apr 12, 2022 · 1 comment
Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues. Type: Cleanup Improve and cleanup code base

Comments

@martin-strecker-sonarsource
Copy link
Contributor

In MethodParameterLookupBase a code comment references the Roslyn issue dotnet/roslyn#9 as the proper way to find the syntax node belonging to a parameter name or IParameterSymbol. In dotnet/roslyn#9 (comment) IArgumentOperation.Parameter is proposed as a proper replacement for the functionality requested by IMethodParameterLookup.

There are VB and C# implementations for IMethodParameterLookup which maybe could be unified and simplified by using IArgumentOperation.Parameter.
@pavel-mikula-sonarsource pavel-mikula-sonarsource added Area: VB.NET VB.NET rules related issues. Area: C# C# rules related issues. labels Apr 13, 2022
@pavel-mikula-sonarsource
Copy link
Contributor

We'll need to verify how that behaves on old Roslyn versions.

@pavel-mikula-sonarsource pavel-mikula-sonarsource added Type: Cleanup Improve and cleanup code base and removed Type: Improvement labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues. Type: Cleanup Improve and cleanup code base
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pavel-mikula-sonarsource @martin-strecker-sonarsource