-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create rule S7173: "GoSub" statements should not be used #4580
Conversation
6d97e37
to
05cc2be
Compare
rules/S7173/vb6/rule.adoc
Outdated
=== Exceptions | ||
|
||
`On Error GoSub` statements are ignored as correct error handling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is an exception for GoTo so I kept it but I am not sure if this valid or even still relevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not mistaken error handlers have to be inside a function / sub to be available with GoTo
so I would strongly guess that GoSub
is not possible in this context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments.
rules/S7173/vb6/rule.adoc
Outdated
=== Exceptions | ||
|
||
`On Error GoSub` statements are ignored as correct error handling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not mistaken error handlers have to be inside a function / sub to be available with GoTo
so I would strongly guess that GoSub
is not possible in this context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Gate passed for 'rspec-tools'Issues Measures |
Quality Gate passed for 'rspec-frontend'Issues Measures |
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: