Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS script not added to page #2

Closed
tomzx opened this issue Jul 4, 2015 · 3 comments
Closed

JS script not added to page #2

tomzx opened this issue Jul 4, 2015 · 3 comments

Comments

@tomzx
Copy link

tomzx commented Jul 4, 2015

It appears that $this->modified is not set to true for some reason, which prevents the addition of the required js file in the generate page. Thus, I end up with a raw equation being displayed in the page.

If I remove the !$this->modified` condition from line 168 (

if (!$config->get('process', false) || !$this->modified) {
), I get it to load the JS files and display the equation image.

    // Skip if process is set to false
    if (!$config->get('process', false) || !$this->modified) {
      return;
    }
@Sommerregen
Copy link
Owner

I know I was implementing a technique to add assets dynamically to a page even if page caching was on. This is a stub and I recently learned that with Grav it is not possible to do such things. However at that time I released the feature it was working at least on a page. On a modular page I don't know and have to test it. Unfortunately my time is really limited at the moment. I will keep an eye of the issue here and release a new version as soon as possible.

@dersimn
Copy link

dersimn commented Jul 11, 2015

Had the same issue, @tomzx's fix works fine for me.
I'm running an fresh installation of Grav with one page.

@Sommerregen
Copy link
Owner

This issue is fixed in the current version. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants