From 909b5df1f5fcb8dfee60e242aaf1e864b36a5a6b Mon Sep 17 00:00:00 2001 From: Tomasz Trela Date: Fri, 29 Nov 2024 20:14:50 +0100 Subject: [PATCH 1/4] refactor: fix padding --- lib/config/ui_config.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/config/ui_config.dart b/lib/config/ui_config.dart index 6298e6b1..13e9afb4 100644 --- a/lib/config/ui_config.dart +++ b/lib/config/ui_config.dart @@ -195,7 +195,7 @@ abstract class SksConfig { static const sizedBoxWidth = 5.0; static const radius = 8.0; static const innerPadding = EdgeInsets.symmetric(horizontal: 8, vertical: 4); - static const outerPadding = EdgeInsets.only(right: 12, bottom: 2); + static const outerPadding = EdgeInsets.only(right: 24, bottom: 2); } abstract class NavigationTabViewConfig { From 88e299eee7dab58dabe9946055ef77c27050cbe8 Mon Sep 17 00:00:00 2001 From: Tomasz Trela Date: Fri, 29 Nov 2024 21:14:28 +0100 Subject: [PATCH 2/4] feat: add appbar to closed sks screen --- lib/features/sks-menu/presentation/sks_menu_screen.dart | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/features/sks-menu/presentation/sks_menu_screen.dart b/lib/features/sks-menu/presentation/sks_menu_screen.dart index 40c5d753..d7f5518d 100644 --- a/lib/features/sks-menu/presentation/sks_menu_screen.dart +++ b/lib/features/sks-menu/presentation/sks_menu_screen.dart @@ -94,6 +94,12 @@ class _SKSMenuLottieAnimation extends StatelessWidget { Widget build(BuildContext context) { Logger().e(error.toString()); return Scaffold( + appBar: DetailViewAppBar( + title: context.localize.home_screen, + actions: const [ + SksUserDataButton(), + ], + ), body: Column( mainAxisAlignment: MainAxisAlignment.center, children: [ From bf89a6190011d422a9a2fd67d7ccfad66ac4bde7 Mon Sep 17 00:00:00 2001 From: Tomasz Trela Date: Sat, 30 Nov 2024 20:37:29 +0100 Subject: [PATCH 3/4] refactor/rebase --- lib/features/sks-menu/presentation/sks_menu_screen.dart | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/features/sks-menu/presentation/sks_menu_screen.dart b/lib/features/sks-menu/presentation/sks_menu_screen.dart index d7f5518d..c06e5622 100644 --- a/lib/features/sks-menu/presentation/sks_menu_screen.dart +++ b/lib/features/sks-menu/presentation/sks_menu_screen.dart @@ -95,7 +95,6 @@ class _SKSMenuLottieAnimation extends StatelessWidget { Logger().e(error.toString()); return Scaffold( appBar: DetailViewAppBar( - title: context.localize.home_screen, actions: const [ SksUserDataButton(), ], From 79afe234ecd9717d1cbc020e1ef62b05f1c41192 Mon Sep 17 00:00:00 2001 From: Tomasz Trela Date: Sat, 30 Nov 2024 20:41:30 +0100 Subject: [PATCH 4/4] refactor/separate-padding-values --- lib/config/ui_config.dart | 3 ++- .../navigation_tab_view/widgets/notification_button.dart | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/config/ui_config.dart b/lib/config/ui_config.dart index 13e9afb4..0151531d 100644 --- a/lib/config/ui_config.dart +++ b/lib/config/ui_config.dart @@ -195,7 +195,8 @@ abstract class SksConfig { static const sizedBoxWidth = 5.0; static const radius = 8.0; static const innerPadding = EdgeInsets.symmetric(horizontal: 8, vertical: 4); - static const outerPadding = EdgeInsets.only(right: 24, bottom: 2); + static const outerPaddingLarge = EdgeInsets.only(right: 24, bottom: 2); + static const outerPadding = EdgeInsets.only(right: 12, bottom: 2); } abstract class NavigationTabViewConfig { diff --git a/lib/features/navigation_tab_view/widgets/notification_button.dart b/lib/features/navigation_tab_view/widgets/notification_button.dart index 08c3c97f..9c669367 100644 --- a/lib/features/navigation_tab_view/widgets/notification_button.dart +++ b/lib/features/navigation_tab_view/widgets/notification_button.dart @@ -11,7 +11,7 @@ class NotificationButton extends StatelessWidget { @override Widget build(BuildContext context) { return Padding( - padding: SksConfig.outerPadding, + padding: SksConfig.outerPaddingLarge, child: MySplashTile( // TODO(simon-the-shark): show dialog about our future intented use of notifications onTap: requestFCMPermission,