Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/ add Lottie animation when error occurred or SKS's closed on SKS Menu #395

Closed
mikolaj-jalocha opened this issue Nov 11, 2024 · 0 comments · Fixed by #428
Closed

feat/ add Lottie animation when error occurred or SKS's closed on SKS Menu #395

mikolaj-jalocha opened this issue Nov 11, 2024 · 0 comments · Fixed by #428
Assignees
@mmzek
Labels
good first issue Good for newcomers
Milestone
v1.2.0 - Mr. Shar...

Comments

@mikolaj-jalocha
Copy link
Member

mikolaj-jalocha commented Nov 11, 2024 •
edited
Loading

Lottie

  • When SKS's closed our API endpoint returns an empty array.
  • Currently in our app in scenario like this a random loading indicator is shown
  • Some fancy Lottie animation could be displayed here, as well as in case of error.
  • Select fine animation from this website and implement it. Please note that not every Lottie animation works on mobile.
  • We already have some animations like that implemented in other parts of code. Maybe some of it could be reused.
@mikolaj-jalocha mikolaj-jalocha converted this from a draft issue Nov 11, 2024
@mikolaj-jalocha mikolaj-jalocha changed the title feat/ add Lottie animation when error occurred or SKS's closed on SKS Menu feat/ add Lottie animation when error occurred or SKS's closed on SKS Menu & handle old menu Nov 17, 2024
@mikolaj-jalocha mikolaj-jalocha mentioned this issue Nov 22, 2024
Merged
@mikolaj-jalocha mikolaj-jalocha linked a pull request Nov 24, 2024 that will close this issue
Feat/add lottie animation #428
Merged
@mikolaj-jalocha mikolaj-jalocha changed the title feat/ add Lottie animation when error occurred or SKS's closed on SKS Menu & handle old menu feat/ add Lottie animation when error occurred or SKS's closed on SKS Menu Nov 24, 2024
@wkrzos wkrzos removed the DEV label Nov 26, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in ToPWR Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmzek mmzek

Labels
good first issue Good for newcomers
Projects
ToPWR
Archived in project
Milestone
v1.2.0 - Mr. Shark, We Have to Cook
Development

Successfully merging a pull request may close this issue.

Feat/add lottie animation Solvro/mobile-topwr
3 participants
@mikolaj-jalocha @wkrzos @mmzek