Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/ add favorite parkings feature #184

Closed
simon-the-shark opened this issue Sep 1, 2024 · 4 comments · Fixed by #193
Closed

feat/ add favorite parkings feature #184

simon-the-shark opened this issue Sep 1, 2024 · 4 comments · Fixed by #193
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@simon-the-shark
Copy link
Member

Zrzut ekranu 2024-09-1 o 21 35 33

Imo replace "info" icon with a heart button
Zrzut ekranu 2024-09-1 o 21 37 23

"favorite" state should be saved to local memory

@simon-the-shark simon-the-shark added the enhancement New feature or request label Sep 1, 2024
@simon-the-shark simon-the-shark added this to the v1.0.0 milestone Sep 1, 2024
@simon-the-shark simon-the-shark moved this to Todo in ToPWR Sep 1, 2024
@mikolaj-jalocha
Copy link
Member

@simon-the-shark WDYT about solution involving this?

@TTomaszPWR If u're short on time, let me know. I'd do the coding with pleasure :-)

@simon-the-shark
Copy link
Member Author

Yeah, shared_preferences is a well known and a good package for storing simple key-value configs locally. It's a good choice for this simple feature. Alternatively if you want more proper database then we can also use e.g. hive (we already use it for graphql cache). But shared prefs will be enough for this case too. I'll accept both of this packages without a problem. If @TTomaszPWR finds any third option we can probably discuss too

@tomasz-trela
Copy link
Member

@simon-the-shark WDYT about solution involving this?

@TTomaszPWR If u're short on time, let me know. I'd do the coding with pleasure :-)

I think I have time to do it

@simon-the-shark
Copy link
Member Author

@TTomaszPWR then go for it and have fun. I'll give you write permissions for the repo

@tomasz-trela tomasz-trela linked a pull request Sep 4, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in ToPWR Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants