Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel behaviour needs further configuration #118

Closed
ColmMassey opened this issue May 24, 2021 · 19 comments
Closed

Panel behaviour needs further configuration #118

ColmMassey opened this issue May 24, 2021 · 19 comments
Assignees

Comments

@ColmMassey
Copy link
Contributor

We need to be able to specify in config file if the panel is open or minimised when the page is first opened.

At the moment we can hide the Show Datasets panel. We need to extend that to hide any of the panels.

@ColmMassey
Copy link
Contributor Author

Is this also the place to start supporting other configurations of the panels, lile the colour of the Teal tab button? @King-Mob

@King-Mob King-Mob self-assigned this Jun 17, 2021
@King-Mob
Copy link
Contributor

King-Mob commented Jun 22, 2021

@ColmMassey I am assuming colour of the tab button is teal unless a suitable hex code is supplied in the config.


I can get the sidebar to open when the page is first opened.

What I'm grappling with at the moment is opening it into a state that looks good i.e. so the directory has a list of entries in it.

There are 2 ways this could happen.

  • The site could wait until after the map data has loaded to open the sidebar, which is when you can see an actual directory. (this is what I've gone with for the moment)
  • The site could refresh the sidebar when the map has loaded.

@ColmMassey
Copy link
Contributor Author

* The site could wait until after the map data has loaded to open the sidebar, which is when you can see an actual directory. (this is what I've gone with for the moment)

You mean the panel slides out only after the map and pins have appeared? That seems fine.

@ColmMassey
Copy link
Contributor Author

Yes, teal as default. ICA colour is #8E0B56

@ColmMassey
Copy link
Contributor Author

Buglet: On phones in landscape when you have panel open on a co-op's details, you can't scroll if there is data offscreen. Not sure how recent this is.

@King-Mob
Copy link
Contributor

@ColmMassey I'm having difficulty replicating this bug. On my phone and on the mobile options on the browser dev tools, I can scroll on the panel.

@ColmMassey
Copy link
Contributor Author

I was testing multiple versions/bugs simultaneously. I can't replicate on dev.ica but only on dev.dotcoop and dotcoop, but they are both old versions, so we can ignore.

@ColmMassey
Copy link
Contributor Author

I think the about box is hidden, by default. Needs to be there for ica

@King-Mob
Copy link
Contributor

Sorry, was part of testing the config. Have pushed and deployed the fix.

@ColmMassey
Copy link
Contributor Author

When you select a country from the directory lower down in the list the directory scrolls back up to the top.

@ColmMassey
Copy link
Contributor Author

When you select a country from the directory lower down in the list the directory scrolls back up to the top.

@wu-lee Can you take a peak at this bug and see if it's anything obvious?

@wu-lee
Copy link
Contributor

wu-lee commented Jun 26, 2021

I think the problem is that there's a mouse-click handler bound to the sidebar which sets the focus to the dir-filter element, but only if the width of the window is greater than a medium-large threshold (tablet sized?)

If I comment this line out, this problem seems to be resolved. I can't tell if it breaks some other functionality tho. This line's vintage is February 2020, so it's not something added recently.

https://github.com/SolidarityEconomyAssociation/sea-map/blob/8690c352dc495202605194980e4790b49d709763/www/map-app/app/view/sidebar/directory.js#L55

@ColmMassey
Copy link
Contributor Author

Can I try it out and I can check for any negative consequences?

@wu-lee
Copy link
Contributor

wu-lee commented Jun 28, 2021

Ok, I've deployed it on the dev server.

@ColmMassey
Copy link
Contributor Author

Ok, I've deployed it on the dev server.

That seems to work and doesn't seem to mess anything else up. Can you merge it with thelast of John's changes?

@wu-lee
Copy link
Contributor

wu-lee commented Jun 28, 2021

Ok, done, now on dev

@ColmMassey
Copy link
Contributor Author

Hmmm. There are still differences. It may be just in config files. The tab colour is purple and the about box shouldn't be disabled. I wonder if there was a config version not commited.

@wu-lee
Copy link
Contributor

wu-lee commented Jun 28, 2021

I think I may not have pulled John's latest commits, so tried again and made sure I had them - the about page seems to be there now.

@ColmMassey
Copy link
Contributor Author

Okay. Look right now. Have now shared with ICA for approval before pushing to prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants