-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panel behaviour needs further configuration #118
Comments
Is this also the place to start supporting other configurations of the panels, lile the colour of the Teal tab button? @King-Mob |
@ColmMassey I am assuming colour of the tab button is teal unless a suitable hex code is supplied in the config. I can get the sidebar to open when the page is first opened. What I'm grappling with at the moment is opening it into a state that looks good i.e. so the directory has a list of entries in it. There are 2 ways this could happen.
|
You mean the panel slides out only after the map and pins have appeared? That seems fine. |
Yes, teal as default. ICA colour is #8E0B56 |
Buglet: On phones in landscape when you have panel open on a co-op's details, you can't scroll if there is data offscreen. Not sure how recent this is. |
@ColmMassey I'm having difficulty replicating this bug. On my phone and on the mobile options on the browser dev tools, I can scroll on the panel. |
I was testing multiple versions/bugs simultaneously. I can't replicate on dev.ica but only on dev.dotcoop and dotcoop, but they are both old versions, so we can ignore. |
I think the about box is hidden, by default. Needs to be there for ica |
Sorry, was part of testing the config. Have pushed and deployed the fix. |
When you select a country from the directory lower down in the list the directory scrolls back up to the top. |
@wu-lee Can you take a peak at this bug and see if it's anything obvious? |
I think the problem is that there's a mouse-click handler bound to the sidebar which sets the focus to the If I comment this line out, this problem seems to be resolved. I can't tell if it breaks some other functionality tho. This line's vintage is February 2020, so it's not something added recently. |
Can I try it out and I can check for any negative consequences? |
Ok, I've deployed it on the dev server. |
That seems to work and doesn't seem to mess anything else up. Can you merge it with thelast of John's changes? |
Ok, done, now on |
Hmmm. There are still differences. It may be just in config files. The tab colour is purple and the about box shouldn't be disabled. I wonder if there was a config version not commited. |
I think I may not have pulled John's latest commits, so tried again and made sure I had them - the about page seems to be there now. |
Okay. Look right now. Have now shared with ICA for approval before pushing to prod. |
We need to be able to specify in config file if the panel is open or minimised when the page is first opened.
At the moment we can hide the Show Datasets panel. We need to extend that to hide any of the panels.
The text was updated successfully, but these errors were encountered: