Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adoptACLDefault does not copy triples with acl:Authorization #278

Open
megoth opened this issue Mar 22, 2020 · 5 comments
Open

adoptACLDefault does not copy triples with acl:Authorization #278

megoth opened this issue Mar 22, 2020 · 5 comments

Comments

@megoth
Copy link
Contributor

megoth commented Mar 22, 2020

I'm writing tests for the acl module, and noticed that adoptACLDefault does not copy the triples containing acl:Authorization into the new graph it builds. It seems that NSS does not care about this triples though, which is why the bug has gone unnoticed.

I'm creating this issue to verify my suspicion with others. If it is the case that NSS should require acl:Authorization triples, I'll create a bug there as well.

@michielbdejong
Copy link
Contributor

You mean triples like <#owner> rdf:type acl:Authorization? Yes, definitely required to make the semantics work. So that's a double bug then indeed, good catch! :)

@michielbdejong
Copy link
Contributor

Actually a triple bug, Solid UI + NSS + test-suite. :)

@megoth
Copy link
Contributor Author

megoth commented Mar 23, 2020

Ok, I'll create separate issues for NSS and test-suite for this. I'll also try to find the appropriate sections in the Web Access Control specification.

@megoth
Copy link
Contributor Author

megoth commented Mar 23, 2020

I found the issue "Is acl:Authorization mandatory?" in the WAC spec, where the question is discussed as part of the new specification.

I'll keep an eye out for those discussions, but until there's a conclusion I'll wait to create issues on NSS and the test-suite.

That being said, for the sake of semantics I suggest that we make sure that acl:Authorization is added as part of the code we touch in Solid UI and other places. (I've made sure to fix this in in adoptACLDefault in a PR that is coming very soon.)

@timbl
Copy link
Contributor

timbl commented Nov 5, 2020

But meanwhile, we can still fix the fact that the copy doesn't copy it, then, so this issue is still a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants