Add request_response_flow concept to provide easy blocking access to call other defined flows #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please mark whether you used Copilot to assist coding in this PR
|
cyrus2281
reviewed
Sep 16, 2024
| "component_config": { | ||
| "invoke_handler": test_invoke_handler, | ||
| }, | ||
| "request_response_flow_controllers": [ |
There was a problem hiding this comment.
Should we have an example in the example directory as well?
gregmeldrum
approved these changes
Sep 16, 2024
cyrus2281
approved these changes
Sep 16, 2024
* feat: Added a request_response_flow example and fixed a few issues along the way * feat: Reworked the broker_request_response built-in ability of components to be simpler. Instead of having to have a defined flow and then name that flow, it will automatically create a flow with a single broker_request_response component in it. Now there is a straightforward interating function call to allow components to issue a request and get streaming or non-streaming responses from that flow. * chore: fix the request_response example and remove the old one
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows a component to send a message to another flow and receive an iterator back that can be looped over to receive pieces of the response until it is complete. The iterator will simply block until the response is ready, allowing the code to be very straightforward to use.