New timer manager and changed object type for input queues #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…might return None
…er than payload to avoid confusion with message payload
gregmeldrum
approved these changes
Aug 15, 2024
docs/getting_started.md
Outdated
|
|
||
| ```sh | ||
| export OPENAI_API_KEY=<your OpenAI key> | ||
| export OPENAI_API_ENDPOINT=<base url of your OpenAI endpoint> |
There was a problem hiding this comment.
People using the openai endpoint may get confused by the endpoint and model variables in the example. Not sure if it's worthwhile to update the documentation/example, just thinking out loud.
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** NOTE - I had created a PR before that was mistakenly directed straight at SolaceLabs. This one goes to SolaceDev/main where I will assemble a few PRs before cutting a new release from SolaceLabs
This change is a fairly significant refactoring, while still being backwards compatible.
The main purpose of the refactoring was to provide a central timer service for components
It comprises:
Add a central timer manager so that components can request individual timers (and as many as they like)
Change the input queues for components to take an Event type rather than a Message type. The Event, at this moment, can be either a timeout notification or a message to be processed. The ComponentBase will handle either calling 'invoke' on a Message or 'handle_timer_event' if the Event is a timeout. Note that other event types could be added in future.
Change the aggregate component to use the central timer manager
Changed message_filter component to discard messages in the invoke handler
Cleaned up some application shutdown code to not get stuck waiting for threads
Some small test changes to adapt