-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firing 'eqResize' event fails in IE11 #53
Comments
This caused by incorrect detection of CustomEvent feature support so the polyfill is not used in IE11. The generated eq.polyfilled code has check:
but it should be:
|
Merged. Releasing an update soon. |
Im using the latest build 1.7.1 and im still getting this error when IE tries do create the eqResize custom event, is this expected behaviour? |
Btw, the errors im getting happen in IE11, the message is as follows:
And that refers to: Maybe something's still wrong with the polyfill. When using another polyfill such as https://github.com/krambuhl/custom-event-polyfill it does work with any errors. |
Are you using the polyfilled version or not?
|
So sorry Sam. Im using JSPM and for some reason my usual approach to override the entry point is failing in this case. So yeah, I was loading the non-polyfilled despite asking for it. |
Hey @Snugug, could you include a note about CustomEvent in the polyfills section in the readme? |
Execution of line:
eqResizeEvent = new CustomEvent('eqResize', {'detail': eqState});
throws an error in IE11:
SCRIPT445: Object doesn't support this action
I use eq.polyfilled.min.js.
This is due the IE implementation of the CustomEvent - see sindresorhus/devtools-detect#9 (comment)
The text was updated successfully, but these errors were encountered: