-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support host option to pass down to driver #939
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirrk
changed the title
feature: support host option to pass down to driver
feat: support host option to pass down to driver
Mar 18, 2022
Should we not close #926 if this fixes it? Is this a replacement PR for it? |
@alldoami yes, I will reach out Scott to close it. |
/ok-to-test sha=de1d03b |
Integration tests success for de1d03b |
Could you run |
/ok-to-test sha=2b1d9eb |
Integration tests success for 2b1d9eb |
alldoami
approved these changes
Mar 29, 2022
forgot to update the provider docs 😉 |
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the provider to accept a host value that is passed down to the snowflakego driver. In addition, if Host is set it unsets the region value due to the way the driver attempts to hack the region back into the host incorrectly for privatelink.
Test Plan
References
account.region.privatelink.snowflakecomputing.com