Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support host option to pass down to driver #939

Merged
merged 3 commits into from
Mar 29, 2022

Conversation

Dirrk
Copy link
Contributor

@Dirrk Dirrk commented Mar 18, 2022

Allows the provider to accept a host value that is passed down to the snowflakego driver. In addition, if Host is set it unsets the region value due to the way the driver attempts to hack the region back into the host incorrectly for privatelink.

Test Plan

  • acceptance tests

References

  • We built this module into our terraform container and have tested this to validate that it is working with our snowflake setup which only allows privatelink connections.
  • Securing snowflake to only privatelink connections requires blocking public ips via the network security policy and using a custom privatelink domain ie: account.region.privatelink.snowflakecomputing.com
  • This should solve feat: Add AWS privatelink connectivity support #926 as I worked directly with scott on this
  • Should essentially solve Deprecate region #447 while being backward compatible

@Dirrk Dirrk changed the title feature: support host option to pass down to driver feat: support host option to pass down to driver Mar 18, 2022
@alldoami
Copy link
Contributor

Should we not close #926 if this fixes it? Is this a replacement PR for it?

@Dirrk
Copy link
Contributor Author

Dirrk commented Mar 23, 2022

@alldoami yes, I will reach out Scott to close it.

@alldoami
Copy link
Contributor

/ok-to-test sha=de1d03b

@github-actions
Copy link

Integration tests success for de1d03b

@alldoami
Copy link
Contributor

Could you run make docs?

@alldoami
Copy link
Contributor

/ok-to-test sha=2b1d9eb

@github-actions
Copy link

Integration tests success for 2b1d9eb

@alldoami alldoami merged commit f75f102 into Snowflake-Labs:main Mar 29, 2022
@aidanmelen
Copy link
Contributor

forgot to update the provider docs 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants