Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(main): release 0.28.7 #921

Merged
merged 1 commit into from
Mar 15, 2022
Merged

chore(main): release 0.28.7 #921

merged 1 commit into from
Mar 15, 2022

Conversation

czi-github-helper[bot]
Copy link
Contributor

@czi-github-helper czi-github-helper bot commented Mar 14, 2022 •
edited
Loading

🤖 I have created a release beep boop

0.28.7 (2022-03-15)

BugFixes

  • Allow legacy version of GrantIDs to be used with new grant functionality (#923) (b640a60)
  • Make ReadWarehouse compatible with quoted resource identifiers (#907) (72cedc4)
  • sequence import (#775) (e728d2e)

This PR was generated with Release Please. See documentation.

@czi-github-helper czi-github-helper bot added the autorelease: pending Used by the release process label Mar 14, 2022
@github-actions
Copy link

Integration tests success for 20fbd16c992849bbf1c090e3a8a556007ef86372

@czi-github-helper czi-github-helper bot force-pushed the release-please--branches--main branch from 20fbd16 to bc83c36 Compare March 14, 2022 23:12
@github-actions
Copy link

Integration tests success for bc83c368691d592c8162cc716f609c04ea1507ab

@czi-github-helper czi-github-helper bot force-pushed the release-please--branches--main branch from bc83c36 to bc91d39 Compare March 14, 2022 23:56
@github-actions
Copy link

Integration tests success for bc91d392602e4cca835f024fd5cf651f0e900ad0

@czi-github-helper czi-github-helper bot force-pushed the release-please--branches--main branch from bc91d39 to 4676e5c Compare March 15, 2022 02:46
@github-actions
Copy link

Integration tests success for 4676e5c55efe8eeebf08e05d0aedab8e56a997e0

@ChrisIsidora
Copy link
Contributor

@alldoami Can this be released?

@alldoami alldoami merged commit adbb52e into main Mar 15, 2022
@alldoami alldoami deleted the release-please--branches--main branch March 15, 2022 17:41
@czi-github-helper
Copy link
Contributor Author

🤖 Release is at https://github.com/chanzuckerberg/terraform-provider-snowflake/releases/tag/v0.28.7 🌻

@czi-github-helper czi-github-helper bot added autorelease: tagged Used by the release process and removed autorelease: pending Used by the release process labels Mar 15, 2022
@jaeglee0416
Copy link

I wonder if the fix should have been >= 1 on number of fields (for role grants to other roles).

https://registry.terraform.io/providers/chanzuckerberg/snowflake/latest/docs/resources/role_grants

There is only one "required" field role_name.
We're now running into issues with 4 to 6 fields allowed in ID

@jaeglee0416 jaeglee0416 mentioned this pull request Mar 15, 2022
Merged
2 tasks
@daniepett
Copy link
Contributor

daniepett commented Mar 15, 2022 •
edited
Loading

The original code (prior to my first PR), checked if the length was 4 or 5. When only the required field is provided it will use empty strings in the id ie |||true etc. what is the ID of the resource causing this issue?

daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Mar 22, 2022
@czi-github-helper
chore(main): release 0.28.7 (Snowflake-Labs#921)
b0b7869
@snowflake-release-please snowflake-release-please bot mentioned this pull request May 25, 2022
Merged
This was referenced Nov 1, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alldoami alldoami alldoami approved these changes

Assignees
No one assigned
Labels
autorelease: tagged Used by the release process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrisIsidora @jaeglee0416 @daniepett @alldoami