fix: change the function_grant documentation example privilege to usage #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrobison-sb
changed the title
|
You'll need to add comment changes to the schema itself and the example tf file, not the md. The md is auto-generated using a tf docs plugin. Please add changes here: https://github.com/chanzuckerberg/terraform-provider-snowflake/blob/main/pkg/resources/function_grant.go#L65 and https://github.com/chanzuckerberg/terraform-provider-snowflake/blob/main/examples/resources/snowflake_function_grant/resource.tf#L18 |
|
Oops, thanks for correcting me. Have done so. |
|
Sorry, @jrobison-sb you'll also need to run |
…thub.com:jrobison-sb/terraform-provider-snowflake into fix-function-grant-privilege-docs
|
@alldoami thanks, have done so. |
alldoami
approved these changes
Mar 15, 2022
|
/ok-to-test sha=0ec2d8c |
|
Integration tests success for 0ec2d8c |
|
/ok-to-test sha=fe75bf5 |
|
Integration tests success for fe75bf5 |
daniepett
pushed a commit
to daniepett/terraform-provider-snowflake
that referenced
this pull request
Mar 22, 2022
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs for
snowflake_function_grantspecify a privilege that you can't actually use. This changes the doc to use a valid privilege.Test Plan
N/A, documentation only.