fix: Handling of task error_integration nulls #834
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem introduced in #830.
Tested the latest release v0.25.35 and discovered that
DESCRIBE TASK
returns a string "null", rather than an actual NULL. Frustrating, but there seems to be a similar issue withDESCRIBE USER
handled in a similar way.Those with task error notifications preview enabled and any tasks without
error_notification
set will see this:Worse still, when it tries to update the
error_notification
to empty, it produced the following invalid SQL:To fix this, I implemented proper unsetting of that parameter.
Both problems have been around in the pipe implementation of error integration (also me last year #595), which task was largely copied from, so I propagated both fixes there too. Apologies for these oversights!
Test Plan
References