Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add replication support #832

Merged
merged 12 commits into from
Feb 3, 2022

Conversation

anton-chekanov
Copy link
Contributor

Add support for allowing replication of a database and creating a database out of available replica.

Test Plan

  • acceptance tests for database and replica
  • unit tests for database

References

@alldoami alldoami changed the title Add replication support feat: Add replication support Jan 26, 2022
@alldoami
Copy link
Contributor

run make-docs

@alldoami
Copy link
Contributor

/ok-to-test sha=3483cb7

@github-actions
Copy link

Integration tests failure for 3483cb7

@alldoami
Copy link
Contributor

Could you address the test failures?

@anton-chekanov
Copy link
Contributor Author

I believe I have addressed them shortly before your comment, hence the tests being green right now.

@alldoami
Copy link
Contributor

/ok-to-test sha=e5be7ff

@github-actions
Copy link

Integration tests failure for e5be7ff

@alldoami
Copy link
Contributor

database_acceptance_test.go:56: Step 1/4 error: Check failed: Check 4/5 error: snowflake_database.db: Attribute 'replication_is_primary' expected "true", got "false"

@alldoami
Copy link
Contributor

alldoami commented Feb 1, 2022

/ok-to-test sha=da962cd

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Integration tests success for da962cd

@alldoami
Copy link
Contributor

alldoami commented Feb 1, 2022

run make docs

@alldoami
Copy link
Contributor

alldoami commented Feb 3, 2022

/ok-to-test sha=8151fab

@github-actions
Copy link

github-actions bot commented Feb 3, 2022

Integration tests success for 8151fab

@alldoami alldoami merged commit f519cfc into Snowflake-Labs:main Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants