feat: Task error integration #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think you'd be able to add any integration tests for this? |
|
Integration tests would be easy to add, but they would fail for anyone running against a Snowflake account that doesn't have this private preview feature enabled. I added the new field to a few unit tests (and fixed an issue that it discovered), so hopefully that's good enough for now. |
|
/ok-to-test sha=b5b131d |
|
Integration tests success for b5b131d |
alldoami
approved these changes
Jan 26, 2022
1 task
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for private preview task error integration feature. Identical to #595 with pipes, except for tasks.
Test Plan
References