fix: Recreate notification integration when type changes #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test sha=9be038c |
|
run |
|
Integration tests success for 9be038c |
|
Sorry forgot 🤦 Done now! |
|
/ok-to-test sha=416c488 |
|
Integration tests success for 416c488 |
alldoami
approved these changes
Dec 21, 2021
daniepett
pushed a commit
to daniepett/terraform-provider-snowflake
that referenced
this pull request
Feb 9, 2022
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edge case when changing the type of notification integration (e.g. from
AWS_SQStoAWS_SNS) with the same name, Terraform attempts toALTERit, which results in an error because required fields are different depending on the type.This change forces recreation when any of the integration types change.
Test Plan
References