-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Shares can't be updated on table_grant resource #789
Conversation
pull latest from core repo
pull from root
Pull Latest
Merge from chanzuckerberg
@alldoami would love any guidance to get this incorporated as soon as possible. Let me know if you would like to see anything more on this seems pretty straightforward to me |
/ok-to-test sha=261001c |
Integration tests success for 261001c |
Would be great if you could add a test here! https://github.com/chanzuckerberg/terraform-provider-snowflake/blob/main/pkg/resources/external_table_grant_test.go |
@alldoami I am a little confused does the external table grant use the table_grant? |
@alldoami I added a test to |
/ok-to-test sha=fac1c94 |
Thank you for adding the test! It looks good. |
Integration tests success for fac1c94 |
The difference function in the table_grant resource had a hard coded string meaning it only ever calculated the difference for roles not shares.