fix: read Database and Schema name during Stream import #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the stream resource to read both the Database name and the Schema name along with the other attributes so that after importing an existing Stream you are not prompted to recreate the Stream due to the missing values. Update both the unit test and the acceptance test to verify a successful read and import. Addresses Issue 466.
dkduo
changed the title
dkduo
changed the title
dkduo
changed the title
|
/ok-to-test sha=ce708a4 |
|
run |
|
Integration tests success for ce708a4 |
|
/ok-to-test sha=3e3f4e3 |
alldoami
approved these changes
Oct 25, 2021
|
Integration tests success for 3e3f4e3 |
|
Thanks for the quick review @alldoami!! |
daniepett
pushed a commit
to daniepett/terraform-provider-snowflake
that referenced
this pull request
Feb 9, 2022
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the stream resource to read both the Database name and the
Schema name along with the other attributes so that after importing an
existing Stream you are not prompted to recreate the Stream due to the
missing values.
Update both the unit test and the acceptance test to verify a
successful read and import.
Fix the example import command show in the docs.
Issues:
Test Plan
References