-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow empty result when looking for storage integration on refresh #692
fix: Allow empty result when looking for storage integration on refresh #692
Conversation
Turns out you can nolonger |
/ok-to-test sha=71d4885 |
Integration tests success for 71d4885 |
@bneijt could you fix the conflicts and I'll look at it again after? Sorry for the late review! |
/ok-to-test sha=d5a7131 |
Integration tests success for d5a7131 |
Thanks for working on this! |
Trying to refresh the terraform state after deleting an integration, I get the error:
Error: Could not show storage integration: sql: no rows in result set
The issue seems to be that looking for a specific integration does deal with not finding that specific integration, triggering an error instead of allow the refresh flow to continue.
Steps to reproduce:
snowflake_storage_integration
using the providerterraform refresh
to update the stateExpected result:
Actual result:
Error: Could not show storage integration: sql: no rows in result set
Terraform version: 1.0.7
Provider version: 0.25.19
I'm not a go developer, so this PR probably needs tests.