Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add AWS_SQS_IAM_USER_ARN to notification integration #610

Merged
merged 3 commits into from
Jul 20, 2021
Merged

fix: Add AWS_SQS_IAM_USER_ARN to notification integration #610

merged 3 commits into from
Jul 20, 2021

Conversation

gouline
Copy link
Contributor

@gouline gouline commented Jul 20, 2021

Notification integration fixes missed in #595:

  • Add AWS_SQS_IAM_USER_ARN read-only/computed parameter
  • Fix AWS_SQS_EXTERNAL_ID parameter to be read-only/computed, instead of optional
  • Documentation, example and import

Test Plan

  • unit tests
  • acceptance tests

@gouline gouline requested a review from a team as a code owner July 20, 2021 09:05
@gouline gouline requested a review from edulop91 July 20, 2021 09:05
@alldoami
Copy link
Contributor

/ok-to-test sha=e04ad7a

@github-actions
Copy link

Integration tests success for e04ad7a

Copy link
Contributor

@alldoami alldoami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alldoami
Copy link
Contributor

/ok-to-test sha=dd93f6a

@github-actions
Copy link

Integration tests success for dd93f6a

@alldoami alldoami merged commit 82a340a into Snowflake-Labs:main Jul 20, 2021
jtzero pushed a commit to rxrevu/terraform-provider-snowflake that referenced this pull request Aug 19, 2021
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants