fix: Escape String for AS in external table #580
Conversation
|
Integration tests success for c304eebd5fd0747d911c8766538fabcbc853d934 |
| @@ -113,7 +113,7 @@ func (tb *ExternalTableBuilder) Create() string { | |||
| q.WriteString(fmt.Sprintf(` (`)) | |||
| columnDefinitions := []string{} | |||
| for _, columnDefinition := range tb.columns { | |||
| columnDefinitions = append(columnDefinitions, fmt.Sprintf(`"%v" %v AS %v`, EscapeString(columnDefinition["name"]), EscapeString(columnDefinition["type"]), EscapeString(columnDefinition["as"]))) | |||
| columnDefinitions = append(columnDefinitions, fmt.Sprintf(`"%v" %v AS %v`, EscapeString(columnDefinition["name"]), EscapeString(columnDefinition["type"]), columnDefinition["as"])) | |||
There was a problem hiding this comment.
I wonder if a more sustainable fix is to make it so that you can do columnDefinition.Get("name") and it'll return behind the scenes EscapeString(columnDefinition["name"])
There was a problem hiding this comment.
Hmm columnDefinition is a map of strings so there's no Get method.
There was a problem hiding this comment.
it is now, but it doesn't have to be. I don't think you should make that change in the PR though
There was a problem hiding this comment.
Ohhh you were saying to change the structure of columnDefinitions so that we could use Get...
There was a problem hiding this comment.
What would the difference be from what I changed it to?
Addresses: #542
Test Plan
References