fix: Small fixes #3337
Merged
fix: Small fixes #3337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests cancelled for 9be2e1c5319aa2f554cfe9bdf3fd2acdf1e645f8 |
|
Integration tests failure for 0c7aea7fa48092f8e465bf9be5f466dd7717e103 |
sfc-gh-jcieslak
approved these changes
Jan 14, 2025
sfc-gh-jmichalak
approved these changes
Jan 14, 2025
| PreCheck: func() { acc.TestAccPreCheck(t) }, | ||
| TerraformVersionChecks: []tfversion.TerraformVersionCheck{ | ||
| tfversion.RequireAbove(tfversion.Version1_5_0), | ||
| }, |
There was a problem hiding this comment.
Nit: Missing CheckDestroy. This is also missing from other grant ownership tests, should we have a ticket for this?
There was a problem hiding this comment.
Good catch. Added SNOW-1881612.
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Jan 20, 2025
Fixes: - add missing resource monitor as valid option to `snowflake_grant_ownership` (references: [#3318](#3318)) - clarify docs for `snowflake_views` (references: [#3203](#3203)) - add timeouts to `snowflake_execute` (references: [#3334](#3334)) Misc (mostly regarding acceptance tests): - remove vacations notice from readme - document current behavior of multiline attributes in cofig generators when there is whitespace (like `\t`); result of #3307 (comment) - extract okta url to test data
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Jan 20, 2025
Fixes: - add missing resource monitor as valid option to `snowflake_grant_ownership` (references: [#3318](#3318)) - clarify docs for `snowflake_views` (references: [#3203](#3203)) - add timeouts to `snowflake_execute` (references: [#3334](#3334)) Misc (mostly regarding acceptance tests): - remove vacations notice from readme - document current behavior of multiline attributes in cofig generators when there is whitespace (like `\t`); result of #3307 (comment) - extract okta url to test data
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Jan 21, 2025
🤖 I have created a release *beep* *boop* --- ## [1.0.2](v1.0.1...v1.0.2) (2025-01-20) ### 🔧 **Misc** * Generate ID and ObjectType Show Object Methods ([#3292](#3292)) ([f7ff70a](f7ff70a)) * Generate multiline by default ([#3315](#3315)) ([520bb4c](520bb4c)) * Overview of the grant ownership resource ([#3342](#3342)) ([9f891d6](9f891d6)) * Update docs and migration guide ([#3313](#3313)) ([59e333a](59e333a)) ### 🐛 **Bug fixes:** * Fixes in account parameters ([#3310](#3310)) ([96a1f17](96a1f17)) * Handle optional account fields in the state upgrader correctly ([#3330](#3330)) ([4eae4c8](4eae4c8)), closes [#3332](#3332) * Small fixes ([#3337](#3337)) ([8807839](8807839)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
snowflake_grant_ownership(references: #3318)snowflake_views(references: #3203)snowflake_execute(references: #3334)Misc (mostly regarding acceptance tests):
\t); result of chore: Generate marshal json for each model #3307 (comment)