fix:table: Properly read and import table state #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 25, 2020 11:52
kuannie1
approved these changes
Nov 25, 2020
gjv9491
pushed a commit
to gjv9491/terraform-provider-snowflake
that referenced
this pull request
Mar 19, 2021
<!-- Feel free to delete comments as you fill this in --> <!-- summary of changes --> The table.Read functionality wasn't correctly importing all state. For example, we wouldn't set the columns of an imported table. This patch augments the Read function to more fully refresh table state (and therefore the ability to properly import a table). Note that Snowflake doesn't properly "reflect back" some values. For example, if you create a table with `STRING` as a type Snowflake will silently convert it to a VARCHAR(...) type when you query back the col type. ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [x ] acceptance tests <!-- add more below if you think they are relevant --> * [ x] ran in an internal repo to test importing a table (make sure it failed without this patch and then succeed with this patch) ## References <!-- issues documentation links, etc --> *
anton-chekanov
pushed a commit
to anton-chekanov/terraform-provider-snowflake
that referenced
this pull request
Jan 25, 2022
<!-- Feel free to delete comments as you fill this in --> <!-- summary of changes --> The table.Read functionality wasn't correctly importing all state. For example, we wouldn't set the columns of an imported table. This patch augments the Read function to more fully refresh table state (and therefore the ability to properly import a table). Note that Snowflake doesn't properly "reflect back" some values. For example, if you create a table with `STRING` as a type Snowflake will silently convert it to a VARCHAR(...) type when you query back the col type. ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [x ] acceptance tests <!-- add more below if you think they are relevant --> * [ x] ran in an internal repo to test importing a table (make sure it failed without this patch and then succeed with this patch) ## References <!-- issues documentation links, etc --> *
daniepett
pushed a commit
to daniepett/terraform-provider-snowflake
that referenced
this pull request
Feb 9, 2022
<!-- Feel free to delete comments as you fill this in --> <!-- summary of changes --> The table.Read functionality wasn't correctly importing all state. For example, we wouldn't set the columns of an imported table. This patch augments the Read function to more fully refresh table state (and therefore the ability to properly import a table). Note that Snowflake doesn't properly "reflect back" some values. For example, if you create a table with `STRING` as a type Snowflake will silently convert it to a VARCHAR(...) type when you query back the col type. ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [x ] acceptance tests <!-- add more below if you think they are relevant --> * [ x] ran in an internal repo to test importing a table (make sure it failed without this patch and then succeed with this patch) ## References <!-- issues documentation links, etc --> *
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table.Read functionality wasn't correctly importing all state. For example, we wouldn't set the columns of an imported table. This patch augments the Read function to more fully refresh table state (and therefore the ability to properly import a table).
Note that Snowflake doesn't properly "reflect back" some values. For example, if you create a table with
STRINGas a type Snowflake will silently convert it to a VARCHAR(...) type when you query back the col type.Test Plan
References