Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support snowflake application as database #2596

Merged
merged 9 commits into from
Mar 6, 2024

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

Fix for: #1998 and #2366

Changes

  • Because it's the default database it fulfills our if checks for futures, so added a check for name != SNOWFLAKE
  • The second check was added to make it possible to grant privileges on applications by setting object_type to DATABASE
  • Those cases were added to the documentation for the snowflake_grant_privilege_to_account_role resource
  • Added acceptance test that would check if SNOWFLAKE database could be made with object_type = DATABASE
  • I also added a follow-up ticket to add additional tests for applications when they are available.

@sfc-gh-jcieslak sfc-gh-jcieslak marked this pull request as ready for review March 6, 2024 12:29
Copy link

github-actions bot commented Mar 6, 2024

Integration tests failure for fee75f02ca16eddebc7aae1f7f139bb62e3c221a

Copy link

github-actions bot commented Mar 6, 2024

Integration tests failure for 59c501806a557771d0b20092207137d5ddd56743

Copy link

github-actions bot commented Mar 6, 2024

Integration tests failure for 013b88fce128b4429eab3775cbad4e827fc97bd2

Copy link

github-actions bot commented Mar 6, 2024

Integration tests failure for 5a1f25b62a91f92fdf1bc0bca7a86eb5e454293a

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review March 6, 2024 13:15
Copy link

github-actions bot commented Mar 6, 2024

Integration tests failure for e2c3549a1933e1ff182d49074fb1b10e1a1c2bf3

docs/resources/task_grant.md Outdated Show resolved Hide resolved
@sfc-gh-asawicki sfc-gh-asawicki self-requested a review March 6, 2024 13:31
Copy link

github-actions bot commented Mar 6, 2024

Integration tests cancelled for 9bd3b0545fb10a8842b25c352b2b9dc350e84111

@sfc-gh-jcieslak sfc-gh-jcieslak merged commit b9a4a19 into main Mar 6, 2024
8 of 9 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the support-snowflake-application-as-database branch March 6, 2024 13:34
sfc-gh-jcieslak pushed a commit that referenced this pull request Mar 6, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.87.1](v0.87.0...v0.87.1)
(2024-03-06)


### 🔧 **Misc**

* Add deprecated resources/datasources to the main documentation page
([#2581](#2581))
([68bbf4f](68bbf4f))
* Add deprecation message to docs
([#2578](#2578))
([3675d6d](3675d6d))
* Add Terraform setup to the testing pipeline
([#2579](#2579))
([216e35a](216e35a))
* Chore use get or skip in other tests
([#2570](#2570))
([2829b90](2829b90))
* modify provider context to pass snowflake client instead of db
connection
([#2577](#2577))
([e7fd4ef](e7fd4ef))
* Speed up tests
([#2580](#2580))
([f003715](f003715))


### 🐛 **Bug fixes:**

* file_format validate() for field_optionally_enclosed_by
([#2575](#2575))
([5da5d93](5da5d93))
* Fix import for account parameter
([#2594](#2594))
([cac884c](cac884c)),
closes
[#2573](#2573)
* support snowflake application as database
([#2596](#2596))
([b9a4a19](b9a4a19))
* tag identifiers problems
([#2534](#2534))
([3c300e1](3c300e1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants