feat: Add row access policy to the SDK #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for 828955294e2152b7ee80eb9ad3d9196318749d75 |
|
Integration tests failure for 828955294e2152b7ee80eb9ad3d9196318749d75 |
sfc-gh-swinkler
previously approved these changes
Jan 18, 2024
| Name: "h", | ||
| Type: DataTypeVARCHAR, | ||
| }} | ||
| assertOptsValidAndSQLEquals(t, opts, "CREATE ROW ACCESS POLICY %s AS (n VARCHAR, h VARCHAR) RETURNS BOOLEAN -> true", id.FullyQualifiedName()) |
There was a problem hiding this comment.
is it possible to create a row access policy with no arguments?
There was a problem hiding this comment.
Not according to the docs.
There is unit test for no args:
t.Run("validation: [opts.args] should be set", func(t *testing.T) {
opts := defaultOpts()
opts.args = []CreateRowAccessPolicyArgs{}
assertOptsInvalidJoinedErrors(t, opts, errNotSet("CreateRowAccessPolicyOptions", "args"))
})
so we do not allow it.
sfc-gh-jcieslak
approved these changes
Jan 18, 2024
|
Integration tests failure for 37b08f0b1bf2a696fc8bd81e354128e044e0c562 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add row access policy to the SDK
References