Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add COPY GRANTS arg to views resources. #1668

Merged
merged 4 commits into from
Mar 30, 2023
Merged

feat: Add COPY GRANTS arg to views resources. #1668

merged 4 commits into from
Mar 30, 2023

Conversation

sfc-gh-ngaberel
Copy link
Contributor

Test Plan

  • acceptance tests
  • …

References

github-actions[bot]
github-actions bot reviewed Mar 28, 2023
View reviewed changes
pkg/snowflake/view.go Outdated
schema string
secure bool
replace bool
copy_grants bool
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
var-naming: don't use underscores in Go names; struct field copy_grants should be copyGrants (revive)

@github-actions
Copy link

Integration tests failure for 0a955345ef21e490c4c1a55803ac757d66161839

@sfc-gh-ngaberel sfc-gh-ngaberel force-pushed the SNOW-764591-copy-grants branch 2 times, most recently from 5592a1b to 21dce40 Compare March 28, 2023 17:52
@sfc-gh-ngaberel sfc-gh-ngaberel changed the title Add COPY GRANTS arg to views and table resources. feat: Add COPY GRANTS arg to views and table resources. Mar 28, 2023
@github-actions
Copy link

Integration tests failure for 5592a1b17a6f1b210d0063ab814d65c2052c4dd8

@github-actions
Copy link

Integration tests failure for 21dce403216ea82a1cc7a69087eb172aa502c78f

@sfc-gh-ngaberel sfc-gh-ngaberel force-pushed the SNOW-764591-copy-grants branch from 21dce40 to 94a4edb Compare March 28, 2023 18:04
@github-actions
Copy link

Integration tests failure for 94a4edbb7d695eb9e31d64e5f1e7978d93f2709b

@sfc-gh-ngaberel sfc-gh-ngaberel force-pushed the SNOW-764591-copy-grants branch 2 times, most recently from d92a35c to ecceb61 Compare March 28, 2023 18:15
@github-actions
Copy link

Integration tests failure for d92a35cabdfeea62def27b1ebc7b87dbc84a45ef

@github-actions
Copy link

Integration tests failure for ecceb618f5baac3f41600adbdad05dc971c8ab17

@sfc-gh-ngaberel sfc-gh-ngaberel force-pushed the SNOW-764591-copy-grants branch from ecceb61 to c15b373 Compare March 28, 2023 18:53
@github-actions
Copy link

Integration tests failure for c15b373a9cd197ce4a3dedfce49b89374181bddd

sfc-gh-swinkler
sfc-gh-swinkler requested changes Mar 28, 2023
View reviewed changes
pkg/resources/view_acceptance_test.go Outdated Show resolved Hide resolved
pkg/resources/view_test.go Outdated Show resolved Hide resolved
pkg/resources/view.go Outdated Show resolved Hide resolved
@sfc-gh-ngaberel sfc-gh-ngaberel force-pushed the SNOW-764591-copy-grants branch 2 times, most recently from 60128e9 to 0b41448 Compare March 28, 2023 22:42
@github-actions
Copy link

Integration tests failure for 60128e90013a778652679d4abf2659548488a8d3

@github-actions
Copy link

Integration tests failure for 0b41448635a37e42e974d5b3970eee65c6682139

@github-actions
Copy link

Integration tests failure for 874406ac1ccba23f4d8fab89130aea90ca4f6a60

@sfc-gh-swinkler
Copy link
Collaborator 

=== CONT  TestAcc_ViewWithCopyGrants
    view_acceptance_test.go:57: Step 1/1 error: Error running apply: exit status 1
        
        Error: error creating view TKLTYMQYJW
        
          with snowflake_view.test,
          on terraform_plugin_test.tf line 7, in resource "snowflake_view" "test":
           7: resource "snowflake_view" "test" {

@sfc-gh-ngaberel the new acceptance test you wrote is failing. Can you please run this acceptance test locally with verbose (-v) to debug it? This error message is not very helpful in identifying why it failed to created.

@sfc-gh-ngaberel sfc-gh-ngaberel force-pushed the SNOW-764591-copy-grants branch from 874406a to b5d0264 Compare March 30, 2023 00:05
@github-actions
Copy link

Integration tests success for b5d02643e197190efa17a1cbe0c0a6771c32f7fa

@sfc-gh-ngaberel sfc-gh-ngaberel changed the title feat: Add COPY GRANTS arg to views and table resources. feat: Add COPY GRANTS arg to views resources. Mar 30, 2023
@sfc-gh-ngaberel sfc-gh-ngaberel marked this pull request as ready for review March 30, 2023 00:16
@sfc-gh-swinkler sfc-gh-swinkler merged commit 7225d93 into main Mar 30, 2023
@sfc-gh-swinkler sfc-gh-swinkler deleted the SNOW-764591-copy-grants branch March 30, 2023 16:32
@snowflake-release-please snowflake-release-please bot mentioned this pull request Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@sfc-gh-swinkler sfc-gh-swinkler sfc-gh-swinkler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-ngaberel @sfc-gh-swinkler