feat: add GRANT ... ON ALL TABLES IN ... #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Relativity74205 this is very good. I like this a lot. I think i will merge this, get the tests working, and it should be good to go. |
|
@sfc-gh-swinkler Thanks for the review and acceptance. :) Please notify me, if I can assist in getting the tests to work. |
|
@Relativity74205 your code was pretty good as it was, and i didn't have to make too many changes. Its currently released as part of 0.60. Thank you so much! |
|
@Relativity74205 Awesome feature, I've been looking for this for quite a few months 😄 Dropped my resource count from table level 4096 to schema level 106 🎉 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an number of issues, the snowflake feature GRANT SELECT ON ALL TABLES ... (or similar) is requested. I created a prototype of this feature in this branch. Currently it only works for the table resource (not for others).
Before I finish this work (add unit and acceptance tests, implement it on other resources, etc.) I would like to have an opinion if this feature makes sense. Not only how it was implemented, but also generally. Because:
When running e.g. GRANT SELECT ON ALL TABLES IN ..., then Snowflake creates a grant for each individual existing table and there is no way to attribute existing table grants to a GRANT SELECT ON ALL TABLES grant. Thus they cannot be checked (or removed).
Test Plan
tbd
References
#787
#250
#284