Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readded imported privileges special case for database grants #1597

Conversation

Relativity74205
Copy link
Contributor

@Relativity74205 Relativity74205 commented Mar 2, 2023

  • readded imported privileges special case for database grants

It was removed in #1522, however it is needed for the edge case of shared databases (e.g. the snowflake database). In order to give custom roles the permission to use the shared databases, the privilege must be given "IMPORTED PRIVILEGES". However, in the information_schema tables the privilege is shown as "USAGE".

Without this code snippet, the terraform provider wants to regive this permission every time.

Test Plan

  • unit tests
  • manual test with snowflake

References

(https://docs.snowflake.com/en/user-guide/data-exchange-marketplace-privileges)

@Relativity74205 Relativity74205 changed the title fix: fix: readded imported privileges special case for database grants Mar 2, 2023
@Relativity74205
Copy link
Contributor Author

@sfc-gh-swinkler I would be great, if this small fix could be included in the next release as this bug is quite annoying ;)

@Relativity74205
Copy link
Contributor Author

@sfc-gh-swinkler Any chance, if this fix could be merged? The bug is a little anoying

@sfc-gh-swinkler sfc-gh-swinkler merged commit 711ac0c into Snowflake-Labs:main Mar 16, 2023
@sfc-gh-swinkler
Copy link
Collaborator

@Relativity74205. Thank you, i didn't understand why this was in there previously.

@Relativity74205 Relativity74205 deleted the imported_privileges_database_grant branch March 16, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants