Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added force_new option to role grant when the role_name has been changed #1591

Merged
merged 4 commits into from
Mar 2, 2023
Merged

fix: added force_new option to role grant when the role_name has been changed #1591

merged 4 commits into from
Mar 2, 2023

Conversation

Relativity74205
Copy link
Contributor

  • role_grants resource is now recreated if the role_name is changed
  • when refreshing the resource, the code checks now first, if the grantee role still exists (in case it was manually deleted in snowflake)

Test Plan

  • unit tests
  • manuel tests
  • acceptance tests of role_grants module

References

Issue is described in #1590

@Relativity74205 Relativity74205 mentioned this pull request Mar 1, 2023
Closed
@Relativity74205 Relativity74205 changed the title Fix role grants fix: added force_new option to role grant when the role_name has been changed Mar 1, 2023
@sfc-gh-swinkler sfc-gh-swinkler merged commit 4ec3613 into Snowflake-Labs:main Mar 2, 2023
@sfc-gh-swinkler
Copy link
Collaborator

looks good, thanks!

@snowflake-release-please snowflake-release-please bot mentioned this pull request Mar 2, 2023
Merged
sfc-gh-swinkler added a commit that referenced this pull request Mar 2, 2023
@sfc-gh-swinkler
Revert "fix: added force_new option to role grant when the role_name …
1409157 
…has been changed (#1591)"

This reverts commit 4ec3613.
@sfc-gh-swinkler sfc-gh-swinkler mentioned this pull request Mar 2, 2023
Closed
@Relativity74205 Relativity74205 mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-swinkler sfc-gh-swinkler sfc-gh-swinkler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Relativity74205 @sfc-gh-swinkler @AS-auxmoney