Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support object parameters on account level #1583

Merged
merged 6 commits into from
Feb 28, 2023

Conversation

sfc-gh-swinkler
Copy link
Collaborator

fixes #1523

Because object_parameters can also be set at the account level, snowflake_account_parameter now supports setting these, instead of throwing error. Additionally, snowflake_object_parameter has object_type and object_identifier marked as optional, meaning that if they are not set then it will be treated the same as if it was set at the account level.

These two resources are therefore functionally equivalent:

resource "snowflake_object_parameter" "p1" {
  key   = "DATA_RETENTION_TIME_IN_DAYS"
  value = "89"
}

resource "snowflake_account_parameter" "p2" {
  key   = "DATA_RETENTION_TIME_IN_DAYS"
  value = "89"
}

Test Plan

  • acceptance tests

References

Sorry, something went wrong.

pkg/snowflake/parameters.go Outdated Show resolved Hide resolved
pkg/resources/object_parameter.go Outdated Show resolved Hide resolved
@github-actions
Copy link

Integration tests failure for 9e24fbbc3f46ca6a5492884ded9bffd996353478

@github-actions
Copy link

Integration tests success for 29c62eb86fef12b12cbcac3ad67f5e783e3c0c09

@github-actions
Copy link

Integration tests success for 67cd3e14521c0ba99e41eb0609c78f5da1b1a27b

@sfc-gh-swinkler sfc-gh-swinkler merged commit fb24802 into main Feb 28, 2023
@sfc-gh-swinkler sfc-gh-swinkler deleted the object_parameters branch February 28, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter ressource doesn't take the parameter hierarchy into account
1 participant