Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add contributing section to readme #1560

Merged

Conversation

jglapa
Copy link
Contributor

@jglapa jglapa commented Feb 22, 2023

I didn't notice conventional commits are a soft requirement .
I didn't adhere to this in my last contribution.
I thought mentioning this in the readme would be beneficial to any other potential contributors.

@jglapa
Copy link
Contributor Author

jglapa commented Feb 22, 2023

funnily the conventional_commit_title check fails 🙃 I think it's because the merge commits crept in into the PR

@sfc-gh-swinkler sfc-gh-swinkler changed the title Add contributing section to readme fix: Add contributing section to readme Feb 23, 2023
@sfc-gh-swinkler
Copy link
Collaborator

@jglapa this is good, thank you!

@sfc-gh-swinkler sfc-gh-swinkler merged commit 174355d into Snowflake-Labs:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants