Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cleanup grant logic #1522

Merged
merged 26 commits into from
Feb 17, 2023
Merged

fix: cleanup grant logic #1522

merged 26 commits into from
Feb 17, 2023

Conversation

sfc-gh-swinkler
Copy link
Collaborator

Test Plan

  • acceptance tests
  • …

References

@sfc-gh-swinkler sfc-gh-swinkler mentioned this pull request Feb 6, 2023
Closed
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Integration tests failure for 878561474ce03c2783593cdc13a16737a5782eb1

github-actions[bot]
github-actions bot reviewed Feb 6, 2023
View reviewed changes
pkg/resources/grant_helpers.go Outdated Show resolved Hide resolved
pkg/resources/grant_helpers.go Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Integration tests failure for 0a0b2e14820835b201ab8160a9efbb7afb5e57c0

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Integration tests failure for 0f9e3611cdf54087d6dde3365c42f5b94cecf346

github-actions[bot]
github-actions bot reviewed Feb 16, 2023
View reviewed changes
pkg/resources/account_grant.go Outdated Show resolved Hide resolved
pkg/resources/account_grant.go Outdated Show resolved Hide resolved
pkg/resources/account_grant.go Outdated Show resolved Hide resolved
pkg/resources/file_format_grant.go Outdated Show resolved Hide resolved
pkg/resources/function_grant.go Outdated Show resolved Hide resolved
pkg/resources/integration_grant.go Outdated Show resolved Hide resolved
pkg/resources/schema_grant.go Outdated Show resolved Hide resolved
@github-actions
Copy link

Integration tests failure for 2aa943f60d005bed35c8f757cecf5fff87b65065

github-actions[bot]
github-actions bot reviewed Feb 16, 2023
View reviewed changes
pkg/resources/database_grant.go Outdated Show resolved Hide resolved
pkg/resources/database_grant.go Outdated Show resolved Hide resolved
pkg/resources/database_grant.go Outdated Show resolved Hide resolved
@github-actions
Copy link

Integration tests failure for 01468806d3f4c360792cfbc0d86e2ea8060150e4

@github-actions
Copy link

Integration tests failure for e003846534e963bc35c96a479edfd07981d88c30

@github-actions
Copy link

Integration tests failure for b4a2496d69b43e4694708980690143d989b2b8f6

@github-actions
Copy link

Integration tests failure for 707c97f18af6350bbc734ffca82cbe82afabbed6

@github-actions
Copy link

Integration tests failure for 34ca3b313196e3845437357f64fb1c0bae4a4583

@github-actions
Copy link

Integration tests failure for 8944f256a47484f545e2482ebd15d3376ca72dce

@github-actions
Copy link

Integration tests failure for f1f328ac9a611292be8185908af3483e4c36c361

@github-actions
Copy link

Integration tests failure for 8576e6991b6d82dbfc9c9c5e791536eb5e7da62d

@github-actions
Copy link

Integration tests failure for 5c98b55c13e6c1eddb8dea61c4a16c8433d6e497

@github-actions
Copy link

Integration tests failure for bb68a6a0bf3f91cb53b3d117553e2064d0d95f0d

@github-actions
Copy link

Integration tests failure for 9ee983ee66b77210334984cef7cf46d6b05801d2

@github-actions
Copy link

Integration tests failure for a95bbe40cd6d0692ef7e90d10b4ad6695f410a64

@github-actions
Copy link

Integration tests failure for 691ae2d8510b4bac26c1ec3119a882736e1fb802

@github-actions
Copy link

Integration tests success for 24acb493d3600a0ed4b904b58fb5b6c64163a7fe

@github-actions
Copy link

Integration tests failure for f21099a92ac2440115fff4feae2a131d58a8ff9e

@github-actions
Copy link

Integration tests failure for 5708fc2074e67d6b10dda3f763830c1392f5185d

@github-actions
Copy link

Integration tests failure for 262d855ef5e0c178fe66382be9976c83d52a9b03

@github-actions
Copy link

Integration tests failure for 2652203a84d1b66461828c7fcf7c034a1af68f44

@github-actions
Copy link

Integration tests success for 1f3fd2a9ce78369af70f1c1623e68b319a8c1708

@sfc-gh-swinkler sfc-gh-swinkler merged commit 0502c61 into main Feb 17, 2023
@sfc-gh-swinkler sfc-gh-swinkler deleted the cleanup-grant-logic branch February 17, 2023 00:25
@snowflake-release-please snowflake-release-please bot mentioned this pull request Feb 17, 2023
Merged
@bennylu2 bennylu2 mentioned this pull request Feb 17, 2023
Closed
@philippeboyd philippeboyd mentioned this pull request Feb 27, 2023
Closed
@Relativity74205 Relativity74205 mentioned this pull request Mar 2, 2023
Merged
2 tasks
@bennylu2 bennylu2 mentioned this pull request Mar 11, 2023
Closed
@yinxu0619
Copy link

Hi there, I do believe snowflake_warehouse_grant has the same problem as when applying the tf I can see it grants privileges on the warehouse to the role over and over... even it didn't cause any problem but I hope we can fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-swinkler @yinxu0619