Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple share grants #1510

Merged
merged 4 commits into from
Feb 2, 2023
Merged

fix: multiple share grants #1510

merged 4 commits into from
Feb 2, 2023

Conversation

sfc-gh-swinkler
Copy link
Collaborator

@sfc-gh-swinkler sfc-gh-swinkler commented Feb 2, 2023

closes #1459. cleans up some of the logic when enabling multiple grants . Previously if you had two grants that managed the same resources, then one would overwrite the other during subsequent apply.

Test Plan

  • acceptance tests

References

pkg/resources/grant_helpers.go Outdated Show resolved Hide resolved
pkg/resources/grant_helpers.go Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Integration tests failure for 01b8fc25a102411319d57affe0499a9408e0ba65

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Integration tests failure for a42033c1414d0f295d8235b3fae8884cfeffb5bd

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Integration tests failure for bc8a40143cd285c804e468054eebd58211f1f30b

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Integration tests success for db1130e31431095f3e3baa63fbd135ef690e9430

@bennylu2
Copy link
Contributor

bennylu2 commented Feb 3, 2023

@sfc-gh-swinkler there is a bug introduced with version 0.56.3 that is causing any plans with grants to have a perpetual diff

@bennylu2
Copy link
Contributor

bennylu2 commented Feb 3, 2023

This line was removed to check privs

} else if privileges.hasString(priv) && (existingRoles.Contains(roleName) || existingRoles.Len() == 0) && multipleGrantFeatureFlag {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable mutliple grants not working as expected for "snowflake_database_grant" & "snowflake_view_grant"
3 participants