fix: Don't throw an error on unhandled Role Grants #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some preview functionality to Snowflake can result in extra role grants which can break this provider, e.g. `unknown grantee type ...`. While it's not a great idea to update this provider with non-public role grants, it's very helpful to simply ignore the roles that the provider doesn't currently handle.
|
/ok-to-test sha=7753454c |
|
Integration tests success for 7753454c |
sfc-gh-swinkler
approved these changes
Dec 22, 2022
|
@joshelser thank you for your contribution! |
|
Thanks Scott! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some preview functionality to Snowflake can result in extra role grants which can break this provider, e.g.
unknown grantee type .... While it's not a great idea to update this provider with non-public role grants, it's very helpful to simply ignore the roles that the provider doesn't currently handle.Test Plan
References
None
I'll see if I can get the acceptance tests working against such an account.