New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: go syntax #1410

Merged

sfc-gh-swinkler merged 2 commits into Snowflake-Labs:main from mnagaa:fix-syntax

Dec 22, 2022

Contributor

mnagaa commented Dec 8, 2022 •

edited

Loading

This PR fixes lines to use better Go syntax.

increment-decrement: should replace found += 1 with found++
removing underscore

pkg/snowflake/table.go:118:2: var-naming: don't use underscores in Go names; struct field masking_policy should be maskingPolicy (revive)
        masking_policy string

mnagaa added 2 commits

December 8, 2022 10:29


          fix: increment-decrement

3f26050


          fix: remove underscore

ccddc8c

mnagaa mentioned this pull request

fix: Go syntax to add revive #1411

Merged

sfc-gh-swinkler approved these changes

View reviewed changes

sfc-gh-swinkler merged commit c5f6b9f into Snowflake-Labs:main

snowflake-release-please bot mentioned this pull request

chore(main): release 0.54.0 #1431

Merged

Collaborator

sfc-gh-swinkler commented Dec 22, 2022

@mnagaa thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet