Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Go Expression Fix #1384 #1403

Conversation

ChrisIsidora
Copy link
Contributor

@ChrisIsidora ChrisIsidora commented Dec 7, 2022

Fixed missing stmt for #1384 which is blocking the release. Ran also Fmt and Docs

References

@ChrisIsidora ChrisIsidora changed the title Fix: Go Expression Fix #1384 fix: Go Expression Fix #1384 Dec 7, 2022
@ChrisIsidora
Copy link
Contributor Author

@sfc-gh-swinkler Created this PR to unblock and fix all the test errors of #1401

@sfc-gh-swinkler sfc-gh-swinkler merged commit 8936e1a into Snowflake-Labs:main Dec 7, 2022
@ChrisIsidora ChrisIsidora deleted the bugfix/fix-go-expressions-fix branch December 7, 2022 20:39
@sfc-gh-swinkler
Copy link
Collaborator

@ChrisIsidora i appreciate you doing this, but you don't have to feel obligated. I was working on this fix myself in a separate PR here: #1404. Whenever merging a lot of PRs all at once there is bound to be some problems, and I clean them up before release is created.

Rest assured I will make sure this release goes out ASAP, since I know this is important for you.

@ChrisIsidora
Copy link
Contributor Author

@ChrisIsidora i appreciate you doing this, but you don't have to feel obligated. I was working on this fix myself in a separate PR here: #1404. Whenever merging a lot of PRs all at once there is bound to be some problems, and I clean them up before release is created.

Rest assured I will make sure this release goes out ASAP, since I know this is important for you.

@sfc-gh-swinkler Agreed, I was in the flow, feel responsible and just wanted to help and contribute in any way I can as I have done before, regardless of being dependant on a particular release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants