Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preallocate slice #1385

Merged
merged 1 commit into from
Dec 7, 2022
Merged

fix: preallocate slice #1385

merged 1 commit into from
Dec 7, 2022

Conversation

mnagaa
Copy link
Contributor

@mnagaa mnagaa commented Nov 23, 2022

This PR fixes go slice preallocation, and adds prealloc lint rule.

@sfc-gh-swinkler
Copy link
Collaborator

sfc-gh-swinkler commented Dec 7, 2022 •
edited
Loading

always good to see minor performance improvements :)

@sfc-gh-swinkler sfc-gh-swinkler merged commit 9e972c0 into Snowflake-Labs:main Dec 7, 2022
@sfc-gh-swinkler
Copy link
Collaborator

@mnagaa thank you for your contribution!

@snowflake-release-please snowflake-release-please bot mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-swinkler sfc-gh-swinkler sfc-gh-swinkler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mnagaa @sfc-gh-swinkler