feat: Delete ownership grant updates #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cinglish
changed the title
|
This PR adds an attribute, revert_ownership_to, to both the user_ownership_grant and role_ownership_grant resources to transfer ownership to the provided role instead of defaulting to ACCOUNTADMIN. This fixes an issue we were facing in which we could not run terraform destroy successfully due to DROP ROLE statements failing on snowflake_role resources after their respective snowflake_role_ownership resources were deleted. |
sfc-gh-swinkler
requested changes
Nov 2, 2022
|
/ok-to-test sha=d03a4ea |
|
Integration tests success for d03a4ea |
|
@cinglish can you please run |
sfc-gh-swinkler
approved these changes
Nov 7, 2022
|
@cinglish thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
References