Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing t.Helper() for thelper function #1264

Merged

Conversation

mnagaa
Copy link
Contributor

@mnagaa mnagaa commented Oct 9, 2022

Summary

This PR adds t.Helper() to test helper functions.

Test Plan

  • acceptance tests

@mnagaa mnagaa changed the title fix: missing t.Helper for thelper function fix: missing t.Helper() for thelper function Oct 9, 2022
Copy link
Collaborator

@sfc-gh-swinkler sfc-gh-swinkler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-swinkler sfc-gh-swinkler merged commit 17bd501 into Snowflake-Labs:main Oct 11, 2022
@sfc-gh-swinkler
Copy link
Collaborator

@mnagaa thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants