Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table Tags Acceptance Test #1245

Merged

Conversation

ChrisIsidora
Copy link
Contributor

@ChrisIsidora ChrisIsidora commented Sep 29, 2022

Fixed Table Tags Acceptance Test. @sfc-gh-swinkler Some reason this test was failing, this is the fix for that test

Test Plan

  • acceptance tests

References

@sfc-gh-swinkler
Copy link
Collaborator

/ok-to-test sha=3557d97

@sfc-gh-swinkler
Copy link
Collaborator

@ChrisIsidora thanks for this. I am not sure why these tests are suddenly failing. Actually we could even remove them, since tags block on tables has been deprecated in favor of the snowflake_tag_association resource.

@sfc-gh-swinkler sfc-gh-swinkler merged commit ab34763 into Snowflake-Labs:main Sep 29, 2022
@sfc-gh-swinkler
Copy link
Collaborator

@ChrisIsidora thank you for your contribution!

@github-actions
Copy link

Integration tests success for 3557d97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants