-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create a snowflake_user_grant resource. #1193
feat: Create a snowflake_user_grant resource. #1193
Conversation
d830c36
to
1b03a11
Compare
@@ -0,0 +1,2 @@ | |||
# format is user name | | | privilege | true/false for with_grant_option | |||
terraform import snowflake_user_grant.example 'userName|||MONITOR|true' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is with the weird id format? why have |||
instead of |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this format is used everywhere, i'm just trying to follow codebase format
terraform-provider-snowflake/docs/resources/integration_grant.md
Lines 49 to 50 in 72c3180
# format is integration name ||| privilege | true/false for with_grant_option | |
terraform import snowflake_integration_grant.example 'intName|||USAGE|true' |
terraform-provider-snowflake/docs/resources/account_grant.md
Lines 42 to 43 in 72c3180
# format is account name | | | privilege | true/false for with_grant_option | |
terraform import snowflake_account_grant.example 'accountName|||USAGE|true' |
if err != nil { | ||
return err | ||
} | ||
err = d.Set("with_grant_option", grantID.GrantOption) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to read the role to determine if with_grant_option has been set already? it would be nice if this could actually be read, rather than just set from the id. i know we don't do that anywhere else, i am just wondering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
propably yes, i beleive it's better to make in separte PR for it to have the same approach for all grants resources
/ok-to-test sha=1b03a11 |
Integration tests failure for 1b03a11 |
Hello @hleb-lizunkou1 . Getting the following error message when running integration tests:
|
@sfc-gh-swinkler i have updated PR with fix please take a look at last commit |
/ok-to-test sha=a6d207e |
Integration tests failure for a6d207e |
hi @hleb-lizunkou1 can you please run
|
hi @sfc-gh-swinkler i have run |
/ok-to-test sha=0dede64 |
Integration tests success for 0dede64 |
@Hleb-Lizunkou thank you for your contribution! |
Create a snowflake_user_grant resource.
Test Plan
References
(Feature Request) Create resource snowflake_user_grant