fix: Database from share comment on create and docs #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test sha=90d42ee |
|
Integration tests success for 90d42ee |
|
This one's ready to be re-run by the way (I had forgotten to run docs 🤦♂️) |
|
/ok-to-test sha=27632ab |
|
Integration tests success for 27632ab |
sfc-gh-swinkler
approved these changes
Aug 19, 2022
|
thank you for your contribution |
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix setting comment on databases
from_sharecreation, it is currently only applied on subsequent updates.Also make examples in docs more illustrative of using fully-qualified provider name.
Test Plan
References