feat: S3GOV support to storage_integration #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating main
sfc-gh-afedorov
approved these changes
Jul 14, 2022
|
/ok-to-test sha=11774d9 |
|
Integration tests success for 11774d9 |
|
|
||
| descRows := sqlmock.NewRows([]string{ | ||
| "property", "property_type", "property_value", "property_default", | ||
| }).AddRow("ENABLED", "Boolean", true, false). |
There was a problem hiding this comment.
minor comment - could you reformat the lines to be aligned like the following?
.AddRow("ENABLED", "Boolean", true, false)
.AddRow("STORAGE_PROVIDER", "String", "S3GOV", nil)
.AddRow("STORAGE_ALLOWED_LOCATIONS", "List", "s3://bucket-a/path-a/,s3://bucket-b/", nil)
.AddRow("STORAGE_BLOCKED_LOCATIONS", "List", "s3://bucket-c/path-c/,s3://bucket-d/", nil)
...
.AddRow("STORAGE_AWS_EXTERNAL_ID", "String", "AGreatExternalID", nil)
|
/ok-to-test sha=251157d |
|
Integration tests success for 251157d |
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding S3GOV to the storage_provider list in storage_integration resource. Skipped the tests.
Test Plan
References