Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updating shares to disallow account locators #1102

Merged
merged 1 commit into from
Jul 6, 2022
Merged

fix: Updating shares to disallow account locators #1102

merged 1 commit into from
Jul 6, 2022

Conversation

sfc-gh-jalin
Copy link
Contributor

@sfc-gh-jalin sfc-gh-jalin commented Jul 6, 2022 •
edited
Loading

fix: Updating shares to disallow account locators

  • make docs was run
  • unit tests were added for the validation function
  • unit tests successful go test

Test Plan

  • acceptance tests
  • …

References

@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Integration tests success for 4ba67e91f9c8d83c529a36883c2490a391bb9d54

@sfc-gh-jalin sfc-gh-jalin merged commit 4079080 into main Jul 6, 2022
@sfc-gh-jalin sfc-gh-jalin deleted the accLocator branch July 6, 2022 17:35
@snowflake-release-please snowflake-release-please bot mentioned this pull request Jul 6, 2022
Merged
This was referenced Nov 1, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-swinkler sfc-gh-swinkler sfc-gh-swinkler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-jalin @sfc-gh-swinkler