fix: allow custom characters to be ignored from validation #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Integration tests failure for 1cedb3f98b8232610e623a03417b00f419cf8f3a |
|
Integration tests success for b4e66b7facb44451f3fbc4e70d5b8798bc8f45d4 |
|
/ok-to-test sha=b4e66b7 |
|
Integration tests success for b4e66b7 |
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding fix for issue: #1054
Created a new struct parameter for adding characters to exclude from the validation check.
role_ownership_grants is now able to take in periods or "." in the role_name parameter
Test Plan
tested locally and was able to resolve the error for
Error: '.' is not a valid identifier character.References
#1054
*