-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hugging and CompressionResistance Please #344
Comments
Happy to accept a well proposed PR for this but otherwise as per the readme we're currently focusing any feature development exclusively into SnapKit. |
Is really a terrible news, I hope you can combined with the above in SnapKit |
@iStarEternal it's not really terrible news, it's pretty much just me maintaining the two repositories now and I just don't have enough time. Neither project is financially sponsored so I can't just take time off to work on both. |
Sorry for my grammar, my English is not very good. Hope that you can understand what I had written. |
@robertjpayne |
If it helps, please add it to Masonry |
Hey @robertjpayne, I'd like to contribute to this issue and prepare a nice and clean PR. But first I'd like to discuss syntax, logic and probable caveats of the feature. Some of the discussion was started at #88, and @nickynick with @cloudkite pointed out that hugging and compression resistance are somehow out of Mansonry semantics, which is kind of true. On the other hand as far as I know there are underlying constraints to support these properties, though they aren't available to the user directly. I suppose there could be a workaround, like storing the hugging and compression resistance values in an instance of a specialized subclass of And what syntax looks good? The one suggested by @iStarEternal or the one from #88? |
@adubr Nice to meet you! you can download my solution: MASForbearance.zip and try to use it. |
@adubr @iStarEternal it's an interesting feature, I think in some ways @cloudkite is right that semantically it doesn't make much sense to stuff these into the maker API. One could say that a shortcut API would be beneficial, and it's what I've done in the Swift version.
The benefit here is getting rid of the method call and making it just a dynamic property. |
I want to add hugging constraint to a view now, but it is not elegant code to write so
I think you should add this syntax into Masonry
The text was updated successfully, but these errors were encountered: